Fix reproducibility issue for tarballs with symlink #54264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
force-pushed
the
fix-macos-reproducibility-issue-for-tarballs
branch
from
2b5541b to
6795683
Compare
potiuk
force-pushed
the
fix-macos-reproducibility-issue-for-tarballs
branch
from
6795683 to
6733d7f
Compare
Bulk-removing of user and group permissions on MacOS is not a good idea for symlinks for reproducibility, because symlinks on linux cannot have other/group permissions changed but on MacOS they can even if it has no effect. Instead of bulk-change with chmod command we now change the permissions individually on all files except symlinks
potiuk
force-pushed
the
fix-macos-reproducibility-issue-for-tarballs
branch
from
6733d7f to
d5b1961
Compare
Member
Author
|
That was surprisingly complex to get it right |
ashb
approved these changes
Aug 8, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2025
Bulk-removing of user and group permissions on MacOS is not a good idea for symlinks for reproducibility, because symlinks on linux cannot have other/group permissions changed but on MacOS they can even if it has no effect. Instead of bulk-change with chmod command we now change the permissions individually on all files except symlinks (cherry picked from commit 7460176) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 8, 2025
…he#54264) Bulk-removing of user and group permissions on MacOS is not a good idea for symlinks for reproducibility, because symlinks on linux cannot have other/group permissions changed but on MacOS they can even if it has no effect. Instead of bulk-change with chmod command we now change the permissions individually on all files except symlinks (cherry picked from commit 7460176) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 8, 2025
…he#54264) Bulk-removing of user and group permissions on MacOS is not a good idea for symlinks for reproducibility, because symlinks on linux cannot have other/group permissions changed but on MacOS they can even if it has no effect. Instead of bulk-change with chmod command we now change the permissions individually on all files except symlinks (cherry picked from commit 7460176) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Aug 8, 2025
Bulk-removing of user and group permissions on MacOS is not a good idea for symlinks for reproducibility, because symlinks on linux cannot have other/group permissions changed but on MacOS they can even if it has no effect. Instead of bulk-change with chmod command we now change the permissions individually on all files except symlinks (cherry picked from commit 7460176) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Aug 8, 2025
…) (#54267) Bulk-removing of user and group permissions on MacOS is not a good idea for symlinks for reproducibility, because symlinks on linux cannot have other/group permissions changed but on MacOS they can even if it has no effect. Instead of bulk-change with chmod command we now change the permissions individually on all files except symlinks (cherry picked from commit 7460176) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Contributor
|
Cool! |
Member
Author
Yeah - but as - kind of surprsing - this was way more involved than I thought - including the fact that in v3-0-testt cherry-pick I had to adjust the implementation for Python 3.9 🤯 :D. But ... I hope I nailed it for 3.0.5 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk-removing of user and group permissions on MacOS is not a good idea for symlinks for reproducibility, because symlinks on linux cannot have other/group permissions changed but on MacOS they can even if it has no effect. Instead of bulk-change with chmod command we now change the permissions individually on all files except symlinks
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.